From d0fe97884a0c8dc6eebcea9e5439c7bbe35fd91d Mon Sep 17 00:00:00 2001
From: Davide Ferrari <vide@fastmail.com>
Date: Sat, 10 Jan 2026 14:18:57 +0100
Subject: [PATCH] chore: remove unnecessary moshi-kotlin reflection dependency
 (#30)

Remove moshi-kotlin (reflection-based adapter) since the project uses
KSP code generation with @JsonClass(generateAdapter = true).

Benefits:
- Smaller APK size (no reflection library)
- Faster JSON parsing (generated code vs reflection)
- Cleaner dependency tree

Note: The Moshi kapt deprecation warning during hiltJavaCompileDebug
is a known Hilt bug and will persist until Hilt fixes it or Moshi 2.0
removes kapt support entirely.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
---
 app/build.gradle.kts                                | 1 -
 app/src/main/java/com/matedroid/di/NetworkModule.kt | 2 --
 gradle/libs.versions.toml                           | 1 -
 3 files changed, 4 deletions(-)

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 23a6053..50b779c 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -109,7 +109,6 @@ dependencies {
     implementation(libs.okhttp)
     implementation(libs.okhttp.logging)
     implementation(libs.moshi)
-    implementation(libs.moshi.kotlin)
     ksp(libs.moshi.codegen)
 
     // DataStore
diff --git a/app/src/main/java/com/matedroid/di/NetworkModule.kt b/app/src/main/java/com/matedroid/di/NetworkModule.kt
index 1f597d9..ce3febc 100644
--- a/app/src/main/java/com/matedroid/di/NetworkModule.kt
+++ b/app/src/main/java/com/matedroid/di/NetworkModule.kt
@@ -5,7 +5,6 @@ import com.matedroid.data.api.NominatimApi
 import com.matedroid.data.api.TeslamateApi
 import com.matedroid.data.local.SettingsDataStore
 import com.squareup.moshi.Moshi
-import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
 import dagger.Module
 import dagger.Provides
 import dagger.hilt.InstallIn
@@ -32,7 +31,6 @@ object NetworkModule {
     @Singleton
     fun provideMoshi(): Moshi {
         return Moshi.Builder()
-            .addLast(KotlinJsonAdapterFactory())
             .build()
     }
 
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index fb9c15b..a29de05 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -56,7 +56,6 @@ retrofit-converter-moshi = { group = "com.squareup.retrofit2", name = "converter
 okhttp = { group = "com.squareup.okhttp3", name = "okhttp", version.ref = "okhttp" }
 okhttp-logging = { group = "com.squareup.okhttp3", name = "logging-interceptor", version.ref = "okhttp" }
 moshi = { group = "com.squareup.moshi", name = "moshi", version.ref = "moshi" }
-moshi-kotlin = { group = "com.squareup.moshi", name = "moshi-kotlin", version.ref = "moshi" }
 moshi-codegen = { group = "com.squareup.moshi", name = "moshi-kotlin-codegen", version.ref = "moshi" }
 
 # DataStore