yan/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-04-21 18:24:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix vite manifest update masking build errors (#37279)

Browse Source 
Moves the manifest patching from `closeBundle` to `writeBundle`. Thrown
errors in `writeBundle` work correctly and exit the build.

Signed-off-by: silverwind <me@silverwind.io>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
silverwind
2026-04-20 09:10:46 +02:00
committed by GitHub
parent ee253afb86
commit 5a3d8d3224
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
vite.config.ts
View File

@@ -86,7 +86,7 @@ function iifeBuildOpts({sourceFileName, write}: {sourceFileName: string, write?:
} }
// Build iife.js as a blocking IIFE bundle. In dev mode, serves it from memory // Build iife.js as a blocking IIFE bundle. In dev mode, serves it from memory
// and rebuilds on file changes. In prod mode, writes to disk during closeBundle. // and rebuilds on file changes. In prod mode, writes to disk and updates "manifest.json".
function iifePlugin(sourceFileName: string): Plugin { function iifePlugin(sourceFileName: string): Plugin {
let iifeCode = '', iifeMap = ''; let iifeCode = '', iifeMap = '';
const iifeModules = new Set<string>(); const iifeModules = new Set<string>();
@@ -143,7 +143,7 @@ function iifePlugin(sourceFileName: string): Plugin {
} }
}); });
}, },
async closeBundle() { async writeBundle() {
for (const file of globSync(`js/${sourceBaseName}.*.js*`, {cwd: outDir})) unlinkSync(join(outDir, file)); for (const file of globSync(`js/${sourceBaseName}.*.js*`, {cwd: outDir})) unlinkSync(join(outDir, file));
const result = await build(iifeBuildOpts({sourceFileName})); const result = await build(iifeBuildOpts({sourceFileName}));
@@ -152,15 +152,9 @@ function iifePlugin(sourceFileName: string): Plugin {
if (!entry) throw new Error('IIFE build produced no output'); if (!entry) throw new Error('IIFE build produced no output');
const manifestPath = join(outDir, '.vite', 'manifest.json'); const manifestPath = join(outDir, '.vite', 'manifest.json');
try { const manifestData = JSON.parse(readFileSync(manifestPath, 'utf8'));
const manifestData = JSON.parse(readFileSync(manifestPath, 'utf8')); manifestData[`web_src/js/${sourceFileName}`] = {file: entry.fileName, name: sourceBaseName, isEntry: true};
manifestData[`web_src/js/${sourceFileName}`] = {file: entry.fileName, name: sourceBaseName, isEntry: true}; writeFileSync(manifestPath, JSON.stringify(manifestData, null, 2));
writeFileSync(manifestPath, JSON.stringify(manifestData, null, 2));
} catch {
// FIXME: if it throws error here, the real Vite compilation error will be hidden, and makes the debug very difficult
// Need to find a correct way to handle errors.
console.error(`Failed to update manifest for ${sourceFileName}`);
}
}, },
}; };
} }